Fix typos in lib/ #9237
Merged
Fix typos in lib/ #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Aug 29, 2019
behlendorf
requested changes
Aug 29, 2019
|
On Thu, Aug 29, 2019 at 02:06:37PM -0700, Ryan Moeller wrote:
freqlabs requested changes on this pull request.
> @@ -2081,7 +2081,7 @@ zpool_find_import_impl(libpc_handle_t *hdl, importargs_t *iarg)
/*
* Process the cache filtering out any entries which are not
- * for the specificed pool then adding matching label configs.
+ * for the specified pool then adding matching label configs.
A few more changes to help clarify this comment:
```
* Process the cache, filtering out any entries which are not
* for the specified pool. Then, add matching label configs.
If you want I can modify this and push new version.
|
After reading it a few more times I changed my mind. Other than possibly adding a comma, I wouldn't change it. |
behlendorf
approved these changes
Aug 30, 2019
behlendorf
added
Status: Accepted
|
This LGTM. @Gelma just let me know if you plan to further tweak this, I'll hold off integrating this change until you let me know it's ready. |
Thanks a lot for patch review to @freqlabs and @behlendorf Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Well, added the comma. Tell me if you like it in this way. |
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#9237
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes openzfs#9237
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Reviewed-by: Richard Laager <rlaager@wiktel.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net> Closes #9237
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.